UL List Issue

Hi Jason

i am getting an error about this line

<?php foreach ($record['images'] as $upload): ?>

checkout the site.

www.actionmc.com.au/beta/index.php

Hi Jason

i sort of got it working but the issue is that it is displaying all the images it should only show the first image of each bike in the list

I have attached the code again and also the cmsb code.

<?php



// load records
list($custom_motorbikesRecords, $custom_motorbikesMetaData) = getRecords(array(
'tableName' => 'custom_motorbikes',
));

?> <!-- STEP2: Display Records (Paste this where you want your records to be listed) -->
<h1>Custom Motorbikes - List Page Viewer</h1>
<?php foreach ($custom_motorbikesRecords as $record): ?>
Record Number: <?php echo $record['num'] ?><br/>
Title: <?php echo $record['title'] ?><br/>
Features: <?php echo $record['content'] ?><br/>
Text: <?php echo $record['text'] ?><br/>
_link : <a href="<?php echo $record['_link'] ?>"><?php echo $record['_link'] ?></a><br/>


<!-- STEP 2a: Display Uploads for field 'logo' (Paste this anywhere inside STEP2 to display uploads) -->
<!-- Upload Fields: num, createdTime, tableName, fieldName, recordNum, preSaveTempId, filePath, filename, extension, thumbFilePath, isImage, hasThumbnail, urlPath, width, height, thumbUrlPath, thumbWidth, thumbHeight, info1, info2, info3, info4, info5 -->
<?php foreach ($record['logo'] as $upload): ?>
<?php if ($upload['hasThumbnail']): ?>
<img src="<?php echo $upload['thumbUrlPath'] ?>" width="<?php echo $upload['thumbWidth'] ?>" height="<?php echo $upload['thumbHeight'] ?>" alt="" /><br/>

<?php elseif ($upload['isImage']): ?>
<img src="<?php echo $upload['urlPath'] ?>" width="<?php echo $upload['width'] ?>" height="<?php echo $upload['height'] ?>" alt="" /><br/>

<?php else: ?>
<a href="<?php echo $upload['urlPath'] ?>">Download <?php echo $upload['filename'] ?></a><br/>

<?php endif ?>
<?php endforeach ?>
<!-- STEP2a: /Display Uploads -->



<!-- STEP 2a: Display Uploads for field 'upload' (Paste this anywhere inside STEP2 to display uploads) -->
<!-- Upload Fields: num, createdTime, tableName, fieldName, recordNum, preSaveTempId, filePath, filename, extension, thumbFilePath, isImage, hasThumbnail, urlPath, width, height, thumbUrlPath, thumbWidth, thumbHeight, info1, info2, info3, info4, info5 -->
<?php foreach ($record['upload'] as $upload): ?>
<?php if ($upload['hasThumbnail']): ?>
<img src="<?php echo $upload['thumbUrlPath'] ?>" width="<?php echo $upload['thumbWidth'] ?>" height="<?php echo $upload['thumbHeight'] ?>" alt="" /><br/>

<?php elseif ($upload['isImage']): ?>
<img src="<?php echo $upload['urlPath'] ?>" width="<?php echo $upload['width'] ?>" height="<?php echo $upload['height'] ?>" alt="" /><br/>

<?php else: ?>
<a href="<?php echo $upload['urlPath'] ?>">Download <?php echo $upload['filename'] ?></a><br/>

<?php endif ?>
<?php endforeach ?>
<!-- STEP2a: /Display Uploads -->


<hr/>
<?php endforeach ?>

<?php if (!$custom_motorbikesRecords): ?>
No records were found!<br/><br/>
<?php endif ?>
<!-- /STEP2: Display Records -->

Hi,

We can do this by only using a single foreach loop and skipping any record that doesn't have an upload attached to it.

Try this:

<div class="slide2">
<?php
$imageCount = 0;
$imagesPerSlide = 4;
?>

<ul>
<?php foreach ($custom_motorbikesRecords as $record): ?>
<?php if (!$record['upload']) { continue; } ?>

<?php $upload = $record['upload'][0]; ?>
<?php if (++$imageCount % ($imagesPerSlide + 1) == 0):?>
</ul>
<ul>
<?php endif ?>

<li><a href="custom-motorbikes.php"><img src="<?php echo $upload['thumbUrlPath'];?>" alt="" width="<?php echo $upload['thumbWidth4'];?>" height="<?php echo $upload['thumbHeight4'];?>"></a><span><?php echo $record['title'] ?></span></li>

<?php endforeach ?>
</ul>

<?php if (!$custom_motorbikesRecords): ?>
No records were found!<br/><br/>
<?php endif ?>

</div>

Hope this helps

Hi Jason

that sort of worked if you have a look it is dropping an extra image into some of the scrolls

Hi Craig,

Our problem is that we were doing our check BEFORE we ouput and image, where we should have been doing the check AFTER.

Try this:

<div class="slide2">
<?php
$imageCount = 0;
$imagesPerSlide = 4;
?>

<ul>
<?php foreach ($custom_motorbikesRecords as $record): ?>
<?php if (!$record['upload']) { continue; } ?>

<?php $upload = $record['upload'][0]; ?>

<li><a href="custom-motorbikes.php"><img src="<?php echo $upload['thumbUrlPath'];?>" alt="" width="<?php echo $upload['thumbWidth4'];?>" height="<?php echo $upload['thumbHeight4'];?>"></a><span><?php echo $record['title'] ?></span></li>

<?php if (++$imageCount % ($imagesPerSlide + 1) == 0):?>
</ul>
<ul>
<?php endif ?>

<?php endforeach ?>
</ul>

<?php if (!$custom_motorbikesRecords): ?>
No records were found!<br/><br/>
<?php endif ?>

</div>

This should work better.

Hi Jason

still not working right it is showing that one extra image per slide.

Hi Craig,

Try changing the if statement to this:

<?php if (++$imageCount % $imagesPerSlide == 0):?>
</ul>
<ul>
<?php endif ?>

Since we're now doing the check after the image is outputted and now before, we want to use $imagesPerSlide, not $imagesPerSlide +1 in our check.

Hope this helps

Hi Jason

perfect thank you very much it looks good now.