Creating Variables

Hi Jerry,

I'm wondering about this section of the code:

<?php if ($record['board_of_director_position_2:label'] == 
$positiona && $positiona && 
$record['board_of_director_position_2_email'] == '1'): ?>
 <?php  $positionb = $record['email']?>
 <?php endif ?>

 <?php if ($record['board_of_director_position_3:label'] == 
$positiona && $positiona && 
$record['board_of_director_position_3_email'] == '1'): ?>
 <?php $positionb = $record['email']?>

Should it be the following

<?php if ($record['board_of_director_position_2:label'] == 
$positionb && $positionb && 
$record['board_of_director_position_2_email'] == '1'): ?>
 <?php  $positionb = $record['email']?>
 <?php endif ?>

 <?php if ($record['board_of_director_position_3:label'] == 
$positionc && $positionc && 
$record['board_of_director_position_3_email'] == '1'): ?>
 <?php $positionc = $record['email']?>

...changing the position variable to be 'b' and 'c' respectively for position_2 and postion_3?

I'm not the best at coding (by a long shot), but it looked like the referencing for position_1 might need to be 'positiona', position_2 as 'positionb' and position_3 as 'positionc'. 

Yeah, this looks like it could be a problem with the variable names getting mixed up.

Jerry, can you confirm that the code is doing the right thing?

Hi Claire, Equinox,

Thanks to your suggestions, I think I’ve sorted out the variable logic and have renamed the variables so that they are less confusing to me and to everyone else.

I can get a listing of the created variables by echoing the values in the line:

<?php '$'; ?><?php $formatted_position ?><?php '='; ?><?php $email_to_use ; ?><?php ';' ; // This is the code that is supposed to create the variables ?>

They are all correct, and render like this:

$president=presidents_real_email@comcast.net;$vice_president=vice_presidents_real_email@gmail.com;$secretary= secretarys_real_email@hotmail.com; etc.

However I’m not sure if these variables are ever fed to the $emailTo in the email header, based on the selected $FTGreason option in the form, and haven’t had any luck trying to determine that.

Here’s the new cleaned up code to check for existing positions and email assignments, and to create the variables:

<?php list($board_of_director_positionsRecords, $board_of_director_positionsMetaData) = getRecords(array(
    'tableName'   => 'board_of_director_positions',
   ));
     $directorposition = array_filter(array_pluck($board_of_director_positionsRecords, 'position'));
   list($accountsRecords, $accountsMetaData) = getRecords(array(
    'tableName'   => 'accounts',
'where' => "board_of_director_position_1_email  LIKE '%1%' OR  board_of_director_position_2_email  LIKE '%1%' OR board_of_director_position_3_email  LIKE '%1%' ",
  ));
    ?>
<?php foreach ($directorposition as $actual_position): ?>
<?php foreach ($accountsRecords as $record): ?>
<?php if ($record['board_of_director_position_1:label'] == $actual_position || $record['board_of_director_position_2:label'] == $actual_position || $record['board_of_director_position_3:label'] == $actual_position): // is there a position selected  ?>
<?php $formatted_position = strtolower($actual_position); // format the position ?>
<?PHP $formatted_position = preg_replace('/\s+/', '_', $formatted_position ); ?>
<?PHP $formatted_position = preg_replace('/-/', '_', $formatted_position ); ?>
<?php if ($record['board_of_director_position_1:label'] == $actual_position && $actual_position && $record['board_of_director_position_1_email'] == '1'): // is this records email address the one to use  ?>
<?php $email_to_use = $record['email']?>
<?php endif ?>
<?php if ($record['board_of_director_position_2:label'] == $actual_position && $actual_position && $record['board_of_director_position_2_email'] == '1'): ?>
<?php  $email_to_use = $record['email']?>
<?php endif ?>
<?php if ($record['board_of_director_position_3:label'] == $actual_position && $actual_position && $record['board_of_director_position_3_email'] == '1'): ?>
<?php $email_to_use = $record['email']?>
<?php endif ?>
<?php '$'; ?><?php $formatted_position ?><?php '='; ?><?php $email_to_use ; ?><?php ';' ; // This is the code that is supposed to create the variables ?>
<?php endif ?>
<?php endforeach ?>
<?php endforeach ?>

And here’s an example of the code that’s supposed to send the email to the selected position:

 if ($FTGreason == "President") {
 
  $emailTo = $president;
   
  $emailFrom = FilterCChars("$FTGemail");
   
  $emailHeader = "From: $emailFrom\n"
   . "MIME-Version: 1.0\n"
   . "Content-type: text/plain; charset=\"UTF-8\"\n"
   . "Content-transfer-encoding: 8bit\n";
   
  mail($emailTo, $emailSubject, $emailBody, $emailHeader);
 
 }

I've attached the latest version of the complete set of pages so that you can see the code in context.

Thanks again for all of this.

Jerry Kornbluth

Hi Jerry

I suspect this has something to do with the FTGreason variable. Just before you get to the check if($FTGreason == "President"), add the following code to see if the variables are being processed correctly:

var_dump($FTGreason);
var_dump("President");
die;

What you should see is some information like string(9) "President". The var_dump will show you what FTGreason actually is just before it hits this check, and it won't pass and execute the email code if it doesn't match what you expect it to be. This is by far the most common reason that if-statements stop working, and I've been caught by it so many times it's the first thing I look at when troubleshooting.

The die statement will obviously kill the script so it'll output the var_dump without processing any further.

Hi Claire,

Thanks for the tip.

Here's the code I inserted after the if statement in apbc_master_form_BOD13_php.php (I added  var_dump ($president);):

 if ($FTGreason == "President") {
 
  $emailTo = $president;
   var_dump($FTGreason);
var_dump("President");
var_dump ($president);
die;

And here's what I got back

string(9) "President" string(9) "President" NULL

So it seems that the $FTGreason is as expected.

Problem is, I don't have any idea why the $president variable is NULL, unless the variables are not being created at all.

Any chance you can take a closer look?

Would you need FTP access?

Thanks,

Jerry

It might be more simple than you think. I looked through the code, and there's only one reference to $president:

$emailTo = $president;

So clearly it's not being set anywhere. Is it a global variable?

The mail function will fail without a valid email address, obviously enough.

Thanks for looking at this Claire,

The variables are supposed to be set in the lines preceding 36 and if I add echo to the various components of line 33 I can see a set of variables that is correct. (but of course it also breaks the page)

The issue must lie in my attempt to create a series of variables line 33, but I don't know what it is.

Jerry

Jerry, I'm looking at this now, and I've just realized what you're trying to do on line 33. That's never going to work - you need variable variables, which is, eh, maybe a little tricky to get handle on.

At the moment all you're doing is outputting a string, which PHP will produce but which won't actually set anything.

Try changing the line as follows:

<?php $$formatted_position = $email_to_use; ?>

The extra $ is not a typo. This may or may not work. It's supposed to create a variable using the name stored in $formatted_position and assign it the value in $email_to_use.